Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made change to sonarrAPI. Changed lookupSeries to lookup_series #63

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Conversation

m0thm4n
Copy link
Contributor

@m0thm4n m0thm4n commented Mar 6, 2021

Description

When attempting to call the lookup_series function it would throw an error because it was using the old function call lookupSeries instead of lookup_series

Related issues

Pull github repo and write a script to utilize the lookup_series function built into the SonarrAPI

Motivation and Context

Because at the moment the package doesn't work without changing the code

How has this been tested

I am building a discord bot to utilize this library

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988 marksie1988 added the type/bug Something isn't working label Mar 6, 2021
@marksie1988
Copy link
Collaborator

Thanks for this, I'll get it merged and published as soon as I'm at my computer so that I can publish a new release.

@marksie1988
Copy link
Collaborator

@m0thm4n I have just done a quick review, please could you bump the version to: 1.0.1

https://github.com/m0thm4n/pyarr/blob/master/pyproject.toml#L3

Once updated I will get this merged :)

@m0thm4n
Copy link
Contributor Author

m0thm4n commented Mar 6, 2021

I have updated the version to 1.0.1

@marksie1988 marksie1988 merged commit 28f0f5a into totaldebug:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants